xuanyuanking commented on a change in pull request #25850: [SPARK-29177] [Core]
fix zombie tasks after stage abort
URL: https://github.com/apache/spark/pull/25850#discussion_r326717287
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala
##########
@@ -64,6 +64,8 @@ private[spark] class TaskResultGetter(sparkEnv: SparkEnv,
scheduler: TaskSchedul
val (result, size) =
serializer.get().deserialize[TaskResult[_]](serializedData) match {
case directResult: DirectTaskResult[_] =>
if (!taskSetManager.canFetchMoreResults(serializedData.limit()))
{
+ scheduler.handleFailedTask(taskSetManager, tid,
TaskState.KILLED, TaskKilled(
Review comment:
How about directly call `taskSetManager.handleFailedTask` here?
If `canFetchMoreResults` return false, taskSetManger.isZombie has set to
true. `scheduler.handlerFailedTask` equally same with
`taskSetManager.handleFailedTask`, and this will make UT easy to write.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
