dongjoon-hyun commented on a change in pull request #25807: [SPARK-25153][SQL]
Improve error messages for columns with dots/periods
URL: https://github.com/apache/spark/pull/25807#discussion_r326844541
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -1841,6 +1842,24 @@ class DatasetSuite extends QueryTest with
SharedSparkSession {
val instant = java.time.Instant.parse("2019-03-30T09:54:00Z")
assert(spark.range(1).map { _ => instant }.head === instant)
}
+
+ val dotColumnTestModes = Table(
+ ("caseSensitive", "colName"),
+ ("true", "field.1"),
+ ("false", "Field.1")
+ )
+
+ test("SPARK-25153: Improve error messages for columns with dots/periods") {
+ forAll(dotColumnTestModes) { (caseSensitive, colName) =>
+ val ds = Seq(SpecialCharClass("1", "2")).toDS
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> caseSensitive) {
+ val errorMsg = intercept[AnalysisException] {
+ ds(colName)
+ }
+ assert(errorMsg.getMessage.contains(s"did you mean to quote the
`${colName}` column?"))
Review comment:
nit. `${colName}` -> `$colName`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
