GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/4264
[SPARK-5475][CORE] Java 8 tests are like maintenance overhead.
Having tests that validate the same code compatible with java 8 and java 7
is like asserting that java 8 is backward compatible with java 7 and still
supports java 8 features(lambda expressions to be precise). This was once
necessary as asm was not compatible with java 8 and so on.
Running java8-tests on the current code base results in more than 100
compilation errors, it felt as if they are never run. This is based on the fact
that compilation errors have existed for a pretty long period. So IMHO, we
should really remove them, if we don't plan to maintain.
Thoughts?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark-1
SPARK-5475/java8-tests-remove
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4264.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4264
----
commit ba716cbbbfecbeb891e05acb82a276cd1af51183
Author: Prashant Sharma <[email protected]>
Date: 2015-01-29T05:32:56Z
[SPARK-5475][CORE] Java 8 tests are like maintenance overhead.
Having tests that validate the same code compatible with java 8 and java 7
is like asserting that java 8 is backward compatible with java 7 and still
supports java 8 features(lambda expressions to be precise). This was once
necessary as asm was not compatible with java 8 and so on.
Running java8-tests on the current code base results in more than 100
compilation errors, it felt as if they are never run. This is based on the fact
that compilation errors have existed for a pretty long period. So IMHO, we
should really remove them, if we don't plan to maintain.
Thoughts?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
