dongjoon-hyun commented on a change in pull request #25788:
[SPARK-29084][SQL][TESTS] Check method bytecode size in BenchmarkQueryTest
URL: https://github.com/apache/spark/pull/25788#discussion_r326877512
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala
##########
@@ -82,13 +82,17 @@ class TPCDSQuerySuite extends BenchmarkQueryTest with
TPCDSSchema {
"q3", "q7", "q10", "q19", "q27", "q34", "q42", "q43", "q46", "q52", "q53",
"q55", "q59",
"q63", "q65", "q68", "q73", "q79", "q89", "q98", "ss_max")
+ // List up the known queries having too large code in a generated function
+ val blackListForMethodCodeSizeCheck = Set("modified-q3")
Review comment:
Can we have an IDed TODO to remove this, @maropu ? SPARK-29128 is the one
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
