maropu commented on a change in pull request #25878: [SPARK-29162][SQL]Simplify
NOT(IsNull(x)) and NOT(IsNotNull(x))
URL: https://github.com/apache/spark/pull/25878#discussion_r326878751
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3192,6 +3192,19 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession {
checkAnswer(df3, Array(Row(new
java.math.BigDecimal("0.100000000000000000000000100"))))
}
}
+
+ test("SPARK-29152: Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))") {
Review comment:
nit: I personally think the `SimplifyConditionalSuite` test is enough for
this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
