Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4260#issuecomment-71982263
@rxin The ALS join code is much easier to read now:) I hope UDFs can be
used as functions instead of an argument of `callUDF`. Besides, it would be
nice to interpret strings as columns by default and force using `Literal` for
constant strings. (I'm limited by the scope of ML usages.) Those could be done
in follow-up PRs. The ML changes in this PR looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
