srowen commented on a change in pull request #25882:
[SPARK-29053][SPARK-28599][WEBUI][2.4] Sort does not work on some columns
URL: https://github.com/apache/spark/pull/25882#discussion_r326905285
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
##########
@@ -100,7 +100,8 @@ private[ui] class ThriftServerSessionPage(parent:
ThriftServerTab)
<td>{info.groupId}</td>
<td>{formatDate(info.startTimestamp)}</td>
<td>{formatDate(info.finishTimestamp)}</td>
- <td>{formatDurationOption(Some(info.totalTime))}</td>
Review comment:
I see, these are really duplicates? I would first merge
https://github.com/apache/spark/pull/25892 then, but, hm, how is it not a merge
conflict? I'm missing something.
My larger point was: does this actually mean you sort all of the entries
when there are many pages of them? or just the current page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
