d80tb7 commented on issue #24981: [SPARK-27463][PYTHON] Support Dataframe Cogroup via Pandas UDFs URL: https://github.com/apache/spark/pull/24981#issuecomment-534010807 Thanks for the review @HyukjinKwon. I'm happy to prepare a PR with the changes you requested, please just let me know how to proceed. Specifically: 1. Do you want to back out this change and then I can put in a new PR? Or do you want me to simply put in a new PR for the changes? 2. Regarding the refactorings of BasePandasGroupExec and BaseArrowPythonRunner do you want me to remove the base clasess and instead duplicate the code in the group/cogroup code paths? FWIW I don't think this is the correct thing to do as this would lead to a high ratio of duplicated code:unique functionality but I understand your point of leaving the refactoring until later so if you think we should duplicate then I am fine with that. many thanks, Chris
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
