srowen commented on a change in pull request #25889: 
[SPARK-29202][Deploy]driver java options are not passed to driver process in 
Yarn client mode
URL: https://github.com/apache/spark/pull/25889#discussion_r327112414
 
 

 ##########
 File path: 
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
 ##########
 @@ -250,6 +250,34 @@ public void testMissingAppResource() {
     new SparkSubmitCommandBuilder().buildSparkSubmitArgs();
   }
 
+  @Test
+  public void testisClientMode() {
 
 Review comment:
   Very minor: testIsClientMode

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to