amanomer commented on a change in pull request #25905: [SPARK-29218][WEBUI]
Widths of checkboxes in StagePage are too narrow.
URL: https://github.com/apache/spark/pull/25905#discussion_r327279313
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -286,7 +286,7 @@ $(document).ready(function () {
" Show Additional Metrics" +
"</a></div>" +
"<div class='container-fluid container-fluid-div' id='toggle-metrics'
hidden>" +
- "<div><input type='checkbox' class='toggle-vis' id='box-0'
data-column='0'> Select All</div>" +
+ "<div id='select_all' class='select-all-checkbox-div'><input
type='checkbox' class='toggle-vis' id='box-0' data-column='0'> Select
All</div>" +
Review comment:
Just curious, what is the use of `id` and `class` here? How was it working
fine without `id` and `class`? Does it take some default value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
