imback82 commented on a change in pull request #25903: [SPARK-29215][SQL]
current namespace should be tracked in SessionCatalog if the current catalog is
session catalog
URL: https://github.com/apache/spark/pull/25903#discussion_r327391631
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -21,14 +21,20 @@ import scala.collection.mutable
import scala.util.control.NonFatal
import org.apache.spark.internal.Logging
+import org.apache.spark.sql.catalyst.analysis.NoSuchNamespaceException
+import org.apache.spark.sql.catalyst.catalog.SessionCatalog
import org.apache.spark.sql.internal.SQLConf
/**
* A thread-safe manager for [[CatalogPlugin]]s. It tracks all the registered
catalogs, and allow
* the caller to look up a catalog by name.
*/
private[sql]
-class CatalogManager(conf: SQLConf, defaultSessionCatalog: TableCatalog)
extends Logging {
+class CatalogManager(
+ conf: SQLConf,
+ defaultSessionCatalog: TableCatalog,
+ v1SessionCatalog: SessionCatalog) extends Logging {
+ import CatalogManager.SESSION_CATALOG_NAME
Review comment:
You can change line 75 to use `SESSION_CATALOG_NAME` instead of
`CatalogManager.SESSION_CATALOG_NAME`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
