dongjoon-hyun commented on a change in pull request #25905:
[SPARK-29218][WEBUI] Widths of checkboxes in StagePage are too narrow.
URL: https://github.com/apache/spark/pull/25905#discussion_r327416560
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -286,7 +286,7 @@ $(document).ready(function () {
" Show Additional Metrics" +
"</a></div>" +
"<div class='container-fluid container-fluid-div' id='toggle-metrics'
hidden>" +
- "<div><input type='checkbox' class='toggle-vis' id='box-0'
data-column='0'> Select All</div>" +
+ "<div id='select_all' class='select-all-checkbox-div'><input
type='checkbox' class='toggle-vis' id='box-0' data-column='0'> Select
All</div>" +
Review comment:
Looks logical, but I'm wondering why the other browsers(Chrome/Safari) show
correctly without that information. Do you know Chrome also has this issue that
`Pop!_OS` because they might share WebKit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
