wangshuo128 commented on a change in pull request #25902: [SPARK-29213][SQL]
Make it consistent when get notnull output and generate null checks in
FilterExec
URL: https://github.com/apache/spark/pull/25902#discussion_r327418429
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
##########
@@ -117,7 +117,7 @@ case class FilterExec(condition: Expression, child:
SparkPlan)
override def output: Seq[Attribute] = {
child.output.map { a =>
- if (a.nullable && notNullAttributes.contains(a.exprId)) {
+ if (a.nullable && notNullPreds.exists(_.semanticEquals(a))) {
Review comment:
yeah, this will fail all. This change is not good enough. I'll try another
way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
