LantaoJin commented on issue #25840: [SPARK-29166][SQL] Add parameters to limit 
the number of dynamic partitions for data source table
URL: https://github.com/apache/spark/pull/25840#issuecomment-534395761
 
 
   I found current implementation has a problem that `FileCommitProtocol` is 
SerDe within closure. So  the member `totalPartitions` in 
`SQLHadoopMapReduceCommitProtocol` will be initialized per task.
   INSERT INTO ... SELECT ... DISTRIBUTE BY will fail in UT.
   I will refactor it. Now mark it as WIP.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to