ScrapCodes commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#issuecomment-534535901 Actually, we intended that by using cache the code would be simpler, but it turned otherwise. I think, at the moment, the way it works is, the cache simply holds one instance of a producer and shares it across threads, when kafka parameters change, a fresh instance is created. The older instance, which is relinquished by all the threads is eventually closed. For the above case, we thought that cache would be cleaner solution. Therefore, for this particular issue, I just wanted to reconsider everything. Can we simplify - in other words, can we reduce the amount of code needed?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
