gaborgsomogyi commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#issuecomment-534541196 > Can we simplify - in other words, can we reduce the amount of code needed? The rough stand in terms of lines is the following: `+547 −322 = +225 lines net change because lot of code movement` From this ~225 lines `CachedKafkaProducerSuite` consumes ~155 lines = `~70 lines` Newly added configurations ~25 lines so `~45 lines total addition to the production part`. What do you suggest?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
