dongjoon-hyun commented on a change in pull request #25856: [SPARK-29182][Core]
Cache preferred locations of checkpointed RDD
URL: https://github.com/apache/spark/pull/25856#discussion_r327839448
##########
File path: core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala
##########
@@ -82,14 +83,28 @@ private[spark] class ReliableCheckpointRDD[T: ClassTag](
Array.tabulate(inputFiles.length)(i => new CheckpointRDDPartition(i))
}
+ // Cache of preferred locations of checkpointed files.
+ private[spark] val cachedPreferredLocations: mutable.HashMap[Int,
Seq[String]] =
+ mutable.HashMap.empty
Review comment:
Then, we have two options.
1. Document the limitation in the PR description and `config` document and
continue in this way.
2. Using Guava cache with timeout policy to mitigate the possibility.
For the size, it looks okay according to your estimation. How do you want to
proceed this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
