rdblue commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534795394 It looks like this changes to meaning of `ErrorIfExists` and `Ignore` to `Append`, but that's not a safe. I understand wanting to make incremental changes, but it seems to me like this should be combined with the addition of the catalog and identifier methods that we discussed in the v2 sync to avoid code in master where `Ingore` actually appends data. That's a correctness problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
