Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3233#discussion_r23805787
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorURLClassLoader.scala ---
@@ -32,36 +36,52 @@ private[spark] trait MutableURLClassLoader extends
ClassLoader {
}
private[spark] class ChildExecutorURLClassLoader(urls: Array[URL], parent:
ClassLoader)
- extends MutableURLClassLoader {
+ extends URLClassLoader(urls, null) with MutableURLClassLoader {
+
+ private val parentClassLoader = new ParentClassLoader(parent)
+ private val locks = new ConcurrentHashMap[String, Object]()
--- End diff --
Can we add some doc on why these locks are needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
