HyukjinKwon commented on a change in pull request #25923:
[DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in
Jenkins
URL: https://github.com/apache/spark/pull/25923#discussion_r327918859
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -448,7 +448,12 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
listFilesRecursively(new File(inputFilePath)).flatMap { file =>
val resultFile = file.getAbsolutePath.replace(inputFilePath,
goldenFilePath) + ".out"
val absPath = file.getAbsolutePath
+
+ // Replacing '.' to '_' is an workaround of sbt bug which removes test
name prior to the
+ // last dot in JUnitXmlReportPlugin.
+ // Please refer https://github.com/sbt/sbt/issues/2949
val testCaseName =
absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
+ .replace('.', '_')
Review comment:
It affects the test way of selecting individual SQL test files because `--z`
option is based upon test name. I mean this:
https://github.com/apache/spark/blob/febac9f13cdea7538fdb596f59c621da96fd052d/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
