dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE]
Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
URL: https://github.com/apache/spark/pull/25922#discussion_r327928252
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -537,22 +537,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
*/
private def numExistingExecutors: Int = executorDataMap.size
- override def getExecutorIds(): Seq[String] = {
+ override def getExecutorIds(): Seq[String] = synchronized {
executorDataMap.keySet.toSeq
}
override def isExecutorActive(id: String): Boolean = synchronized {
executorDataMap.contains(id) && !executorsPendingToRemove.contains(id)
}
- override def maxNumConcurrentTasks(): Int = {
+ override def maxNumConcurrentTasks(): Int = synchronized {
executorDataMap.values.map { executor =>
executor.totalCores / scheduler.CPUS_PER_TASK
}.sum
}
// this function is for testing only
- def getExecutorAvailableResources(executorId: String): Map[String,
ExecutorResourceInfo] = {
+ def getExecutorAvailableResources(
+ executorId: String): Map[String, ExecutorResourceInfo] = synchronized {
Review comment:
BTW, this method is testing-only. We may not need for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
