cloud-fan commented on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534890711 @wangshuo128 you are right that we can improve the algorithm further, and we can do it once the bug is fixed. For now let's fix the bug without introducing a regression. That said, for any predicate (not `IsNotNull`), find all its references (e.g. `a` and `b`), and check if there are corresponding `IsNotNull` predicates (e.g. `IsNotNull(a)` and `IsNotNull(b)`). If a reference has a corresponding `IsNotNull` predicate, codegen it first. Otherwise, generate a new `IsNotNull` predicate for it and codegen it, if the reference is a not-nullable attribute.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
