turboFei commented on a change in pull request #25863:
[WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give
duplicate result.
URL: https://github.com/apache/spark/pull/25863#discussion_r328012996
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -147,18 +151,29 @@ object FileCommitProtocol extends Logging {
className: String,
jobId: String,
outputPath: String,
- dynamicPartitionOverwrite: Boolean = false): FileCommitProtocol = {
+ dynamicPartitionOverwrite: Boolean = false,
+ isInsertIntoHadoopFsRelation: Boolean = false,
+ isOverwrite: Boolean = false,
+ staticPartitionKVs: Seq[(String, String)] = Seq.empty[(String, String)]):
Review comment:
@advancedxy
Thanks for your suggestion. I will update the code, comment and UT.
As mentioned in the comment by you, we should disable concurrent appending
to the same partition.
So we can remove the `isOverwrite` parameter here.
It's a good idea to define a `FileSourceWriteDesc` class to escape
`isInsertIntoHadoopFsRelation` and `staticPartitionKVs`.
Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
