merrily01 commented on a change in pull request #25920:
[SPARK-29233][KUBERNETES] Add regex expression checks for executorEnv…
URL: https://github.com/apache/spark/pull/25920#discussion_r328096342
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
##########
@@ -84,6 +84,7 @@ private[spark] object Constants {
val DEFAULT_EXECUTOR_CONTAINER_NAME = "spark-kubernetes-executor"
val MEMORY_OVERHEAD_MIN_MIB = 384L
val NON_JVM_MEMORY_OVERHEAD_FACTOR = 0.4d
+ val KUBERNETES_EXECUTOR_ENV_REGEX = "[A-Za-z_][A-Za-z0-9_]*"
Review comment:
Thanks for your advice, I have removed the val constant and defined a val in
the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
