srowen commented on a change in pull request #25920: [SPARK-29233][KUBERNETES]
Add regex expression checks for executorEnv…
URL: https://github.com/apache/spark/pull/25920#discussion_r328114556
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##########
@@ -148,7 +149,8 @@ private[spark] class KubernetesExecutorConf(
executorCustomLabels ++ presetLabels
}
- override def environment: Map[String, String] =
sparkConf.getExecutorEnv.toMap
+ override def environment: Map[String, String] =
sparkConf.getExecutorEnv.filter(
Review comment:
This is a nit, but you're using a filter in order to apply a check to each
element. A foreach would be more appropriate and avoid the need to "filter"
when the predicate won't matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
