dongjoon-hyun commented on a change in pull request #25697: [SPARK-28997][SQL]
Add `spark.sql.dialect`
URL: https://github.com/apache/spark/pull/25697#discussion_r328195879
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -818,36 +818,24 @@ class CastSuite extends SparkFunSuite with
ExpressionEvalHelper {
"interval 1 years 3 months -3 days")
}
- test("cast string to boolean") {
- checkCast("true", true)
- checkCast("tru", true)
- checkCast("tr", true)
+ test("cast string to boolean with Spark dialect") {
Review comment:
Shall we remove `with Spark dialect` since we can distinguish with package
name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
