dongjoon-hyun commented on a change in pull request #20640:
[SPARK-19755][Mesos] Blacklist is always active for
MesosCoarseGrainedSchedulerBackend
URL: https://github.com/apache/spark/pull/20640#discussion_r328325996
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
##########
@@ -571,7 +568,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
cpus + totalCoresAcquired <= maxCores &&
mem <= offerMem &&
numExecutors < executorLimit &&
- slaves.get(slaveId).map(_.taskFailures).getOrElse(0) <
MAX_SLAVE_FAILURES &&
+ !scheduler.nodeBlacklist().contains(offerHostname) &&
Review comment:
This checking looks a little late. Can we decline more faster without
calculating everything?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
