rdblue commented on a change in pull request #25651: [SPARK-28948][SQL] Support
passing all Table metadata in TableProvider
URL: https://github.com/apache/spark/pull/25651#discussion_r328329157
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -77,16 +77,15 @@ class CatalogManager(
// If the V2_SESSION_CATALOG config is specified, we try to instantiate the
user-specified v2
// session catalog. Otherwise, return the default session catalog.
def v2SessionCatalog: CatalogPlugin = {
- conf.getConf(SQLConf.V2_SESSION_CATALOG).map { customV2SessionCatalog =>
- try {
- catalogs.getOrElseUpdate(SESSION_CATALOG_NAME, loadV2SessionCatalog())
- } catch {
- case NonFatal(_) =>
- logError(
- "Fail to instantiate the custom v2 session catalog: " +
customV2SessionCatalog)
- defaultSessionCatalog
- }
- }.getOrElse(defaultSessionCatalog)
+ try {
+ catalogs.getOrElseUpdate(SESSION_CATALOG_NAME, loadV2SessionCatalog())
+ } catch {
+ case NonFatal(_) =>
+ logError(
+ "Fail to instantiate the custom v2 session catalog: " +
+ conf.getConfString(CatalogManager.SESSION_CATALOG_NAME))
Review comment:
Why was this error message changed? The previous one that included the
implementation class seems more helpful to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
