GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/4281
[SPARK-5424][MLLIB] make the new ALS impl take generic ID types
This PR makes the ALS implementation take generic ID types, e.g., Long and
String, and expose it as a developer API.
TODO:
- [ ] make sure that specialization works
@srowen You may like this change:) I hit a Scala compiler bug with
specialization. It compiles now but users and items must have the same type.
I'm going to check whether specialization really works.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mengxr/spark generic-als
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4281
----
commit 8bbaea0a3d3f982d4d231b8d1712bdf4c2408732
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-23T07:27:04Z
make ALS take generic IDs
commit 72b50065ee6577f8f87b65785887fce44f7005e9
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T17:39:18Z
remove generic from pipeline interface
commit c8ee0bc9e1aabf93439c2bd8db137edbdac9a0d4
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T17:39:21Z
Merge remote-tracking branch 'apache/master' into generic-als
commit 7a5aeb3a1ed3c90cee8dc7b5766a9fd497f2559b
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T17:40:31Z
UserType -> User, ItemType -> Item
commit e36469ab8e7ee52501ffcd9f4aedce120acaf05c
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T19:01:04Z
add classtags and make it compile
commit 74f1f73ffbaa3346fb81294e8c8e0eb4653e644c
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T20:40:33Z
compile but runtime error at test
commit 86588e1192a509bf5e94c9fc27ed93f507f5b80d
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T20:50:29Z
use a single ID type for both users and items
commit c2db5e512bc9550b0302c5a18bb0dbfe7ef03988
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-29T23:34:45Z
make test pass
commit 135f7417022b34c37c4b56f0e44c943244962d11
Author: Xiangrui Meng <[email protected]>
Date: 2015-01-30T00:16:52Z
minor update
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
