brkyvz commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-535354651 Yes, because the conf turns it back on, specifically to use it On Wed, Sep 25, 2019, 8:26 PM Wenchen Fan <[email protected]> wrote: > *@cloud-fan* commented on this pull request. > ------------------------------ > > In > external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala > <https://github.com/apache/spark/pull/25876#discussion_r328420772>: > > > @@ -400,6 +400,7 @@ abstract class KafkaSinkBatchSuiteBase extends KafkaSinkSuiteBase { > .format("kafka") > .option("kafka.bootstrap.servers", testUtils.brokerAddress) > .option("topic", topic) > + .mode("append") > > Do we still need to change this file since we disable kafka v2 by default? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/25876?email_source=notifications&email_token=ABIAE646Y6C2CZ2TFFW3O4TQLQTU3A5CNFSM4IY4DIE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF67BEY#pullrequestreview-293466259>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABIAE62V7VNOQF2JQYX2XBTQLQTU3ANCNFSM4IY4DIEQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
