srowen commented on a change in pull request #25942: 
[WIP][SPARK-29242][SQL][TEST] Check results of expression examples
URL: https://github.com/apache/spark/pull/25942#discussion_r328608691
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
 ##########
 @@ -140,6 +141,55 @@ class SQLQuerySuite extends QueryTest with 
SharedSparkSession {
     }
   }
 
+  test("check outputs of expression examples") {
 
 Review comment:
   The fixes are good. How long does this take to run, BTW? just want to make 
sure it's not huge to rerun this every time, though I agree testing examples is 
useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to