squito commented on a change in pull request #25823:
[SPARK-28211][Core][Shuffle] Propose Shuffle Driver Components API
URL: https://github.com/apache/spark/pull/25823#discussion_r328679562
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -524,6 +528,19 @@ class SparkContext(config: SparkConf) extends Logging {
executorEnvs ++= _conf.getExecutorEnv
executorEnvs("SPARK_USER") = sparkUser
+ val configuredPluginClasses = conf.get(SHUFFLE_IO_PLUGIN_CLASS)
+ val maybeIO = Utils.loadExtensions(
+ classOf[ShuffleDataIO], Seq(configuredPluginClasses), conf)
+ require(maybeIO.nonEmpty, s"At least one valid shuffle plugin must be
specified by config " +
+ s"${SHUFFLE_IO_PLUGIN_CLASS.key}, but $configuredPluginClasses resulted
in zero valid " +
+ s"plugins.")
+ require(maybeIO.size == 1,
+ s"Specified shuffle plugin(s) $configuredPluginClasses resulted in
more than one valid " +
+ s"plugin, but only one valid plugin should be specified")
+ _shuffleDriverComponents = maybeIO.head.driver()
+ _shuffleDriverComponents.initializeApplication().asScala.foreach {
+ case (k, v) => _conf.set(ShuffleDataIO.SHUFFLE_SPARK_CONF_PREFIX + k, v)
}
Review comment:
Lets log these extra confs at least at the debug level -- though I think I'd
prefer they were logged at info.
is the user alliowed to set "spark.shuffle.plugin." confs themselves? Does
the driver component always get to override whatever the user has set?
I don't have any particular reason to think it should be one way or another,
just want to check if you have any reason to want it to be one way or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
