vanzin commented on a change in pull request #25760: [SPARK-29054][SS]
Invalidate Kafka consumer when new delegation token available
URL: https://github.com/apache/spark/pull/25760#discussion_r328708593
##########
File path:
external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenUtil.scala
##########
@@ -288,4 +288,18 @@ private[spark] object KafkaTokenUtil extends Logging {
params
}
+
+ def isConnectorUsingCurrentToken(params: ju.Map[String, Object]): Boolean = {
+ if (params.containsKey(SaslConfigs.SASL_JAAS_CONFIG)) {
+ logDebug("Delegation token used by connector, checking if uses the
latest token.")
+ val consumerJaasParams =
params.get(SaslConfigs.SASL_JAAS_CONFIG).asInstanceOf[String]
+ val clusterConfig = findMatchingTokenClusterConfig(SparkEnv.get.conf,
Review comment:
My previous comment is marked "outdated" because you changed this line, but
it still applies, so I wanted to make sure it doesn't go unaddressed.
My best suggestion at the moment is to have the cached consumer to do
something like:
```
private val tokenConfig = findMatchingTokenClusterConfig(...)
```
When creating a consumer:
```
val updatedConfigs = KafkaConfigUpdater(...).setAuthInfo(tokenConfig)...
```
And also use that `tokenConfig` when calling this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
