rdblue commented on issue #25945: [SPARK-29248][SQL] Pass in number of partitions to WriteBuilder URL: https://github.com/apache/spark/pull/25945#issuecomment-535704737 The use case seems reasonable to me, as does the approach of adding the number of partitions with a method that is defaulted. I'd like to make sure that all code paths call this method in tests. Could you update the InMemoryTable test class so that it throws an exception if this is not called before a write operation commits? That will ensure in tests that all code paths that commit to a table call this correctly.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
