turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent 
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-535836589
 
 
   > By unblocking the cleanForLogs call, you also unblock the cleaner task 
which may run after it. I didn't see any changes to that code; it should 
probably check whether some path is being processed before trying to do things 
with it.
   
   
   I have checked the code of `cleanLogs`, it will clean up the expired paths 
in `listing` and clear relative record in `blackList`.
   
   In this PR, if a path is contained in `processing`, it would not be added 
into `listing`.
   
   So, should we interrupt the tasks which is processing a path has been 
expired?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to