zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r328973948
########## File path: python/pyspark/ml/feature.py ########## @@ -1415,7 +1440,7 @@ def maxAbs(self): @inherit_doc -class MinHashLSH(JavaEstimator, LSHParams, HasInputCol, HasOutputCol, HasSeed, +class MinHashLSH(JavaEstimator, _LSHParams, HasInputCol, HasOutputCol, HasSeed, Review comment: This place seems a bit different from scala side `MinHashLSH(override val uid: String) extends LSH[MinHashLSHModel] with HasSeed` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
