viirya commented on a change in pull request #25797: [SPARK-29043][Core]
Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r329139175
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -445,7 +460,8 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
// reading a garbage file is safe, but we would log an error which
can be scary to
// the end-user.
!entry.getPath().getName().startsWith(".") &&
- !isBlacklisted(entry.getPath)
+ !isBlacklisted(entry.getPath) &&
+ !isProcessing(entry.getPath)
Review comment:
Filtering a entry currently in processing list, will skip updating
lastProcessed field below. In the end of checkForLogs, the information not
update newest lastProcessed will be deleted. Now checkForLogs is not blocked by
tasks in each iteration, will the entries in processing list be deleted because
their lastProcessed are not updated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
