vanzin commented on a change in pull request #25949: [SPARK-29273] set the
right peakExecutionMemory value when the task end
URL: https://github.com/apache/spark/pull/25949#discussion_r329199464
##########
File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
##########
@@ -647,6 +647,13 @@ private[spark] object JsonProtocol {
val taskInfo = taskInfoFromJson(json \ "Task Info")
val executorMetrics = executorMetricsFromJson(json \ "Task Executor
Metrics")
val taskMetrics = taskMetricsFromJson(json \ "Task Metrics")
+ val peakExecutionMemory = taskInfo.accumulables.find(accInfo => {
Review comment:
This code should be in `taskMetricsFromJson` like other metrics, following
the style over there.
Also, please add a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
