vanzin commented on a change in pull request #25779: [SPARK-27468][core] Track
correct storage level and mem/disk usage for RDDs.
URL: https://github.com/apache/spark/pull/25779#discussion_r329284170
##########
File path: core/src/test/scala/org/apache/spark/status/LiveEntitySuite.scala
##########
@@ -51,6 +52,61 @@ class LiveEntitySuite extends SparkFunSuite {
assert(!seq.exists(_.blockName == items(5).blockName))
}
+ test("rdd tracking in live executor") {
+ val exec = new LiveExecutor("1", 0L)
+ exec.totalOnHeap = 42L
+
+ assert(!exec.hasRDDData(1))
+
+ exec.addBlock(RDDBlockId(1, 1), 1L, 1L, false)
+ assert(exec.hasRDDData(1))
+ assert(exec.diskUsed === 1)
+ assert(exec.memoryUsed === 1)
+ assert(exec.usedOnHeap === 1)
+ assert(exec.usedOffHeap === 0)
+
+ exec.addBlock(RDDBlockId(1, 2), 2L, 2L, false)
+ assert(exec.hasRDDData(1))
+ assert(exec.diskUsed === 3)
+ assert(exec.memoryUsed === 3)
+ assert(exec.usedOnHeap === 3)
+ assert(exec.usedOffHeap === 0)
+
+ val old2 = exec.removeBlock(RDDBlockId(1, 2), false)
+ assert(old2 != null)
+ assert(old2.diskSize === 2)
+ assert(old2.memSize === 2)
+ assert(exec.hasRDDData(1))
+ assert(exec.diskUsed === 1)
+ assert(exec.memoryUsed === 1)
+ assert(exec.usedOnHeap === 1)
+ assert(exec.usedOffHeap === 0)
+
+ val old1 = exec.addBlock(RDDBlockId(1, 1), 3L, 3L, false)
Review comment:
IIRC, if a block is evicted from memory to disk, for example; and later if
it's loaded back into memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
