huaxingao commented on a change in pull request #25947:
[SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
URL: https://github.com/apache/spark/pull/25947#discussion_r329285437
##########
File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
##########
@@ -131,7 +131,7 @@ private[recommendation] trait ALSModelParams extends
Params with HasPredictionCo
* Common params for ALS.
*/
private[recommendation] trait ALSParams extends ALSModelParams with HasMaxIter
with HasRegParam
- with HasPredictionCol with HasCheckpointInterval with HasSeed {
+ with HasCheckpointInterval with HasSeed {
Review comment:
Yes. It seems to be redundant to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
