AngersZhuuuu opened a new pull request #25954: [SPARK-29247][SQL] Redact 
sensitive information in when construct HiveClientHive.state
URL: https://github.com/apache/spark/pull/25954
 
 
   ### What changes were proposed in this pull request?
   
   HiveClientImpl may be log sensitive information. e.g. url, secret and token:
   ```
         logDebug(
           s"""
              |Applying Hadoop/Hive/Spark and extra properties to Hive Conf:
              |$k=${if (k.toLowerCase(Locale.ROOT).contains("password")) "xxx" 
else v}
            """.stripMargin)
   ```
   So redact it.  Use SQLConf.get.redactOptions.
   
   I add a new overloading function to fit this situation for one by one kv 
pair situation.
   
   ### Why are the changes needed?
   Redact sensitive information when construct HiveClientImpl
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   MT
   
   Run command 
   ` /sbin/start-thriftserver.sh`
   
   
   In log we can get 
   ```
   19/09/28 08:27:02 main DEBUG HiveClientImpl:
   Applying Hadoop/Hive/Spark and extra properties to Hive Conf:
   hive.druid.metadata.password=*********(redacted)
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to