turboFei commented on a change in pull request #25863:
[SPARK-28945][SPARK-29037][CORE][SQL] Fix the issue that spark gives duplicate
result and support concurrent file source write operations write to different
partitions in the same table.
URL: https://github.com/apache/spark/pull/25863#discussion_r328205937
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -52,10 +53,14 @@ import org.apache.spark.mapred.SparkHadoopMapRedUtil
class HadoopMapReduceCommitProtocol(
jobId: String,
path: String,
- dynamicPartitionOverwrite: Boolean = false)
+ dynamicPartitionOverwrite: Boolean = false,
+ fileSourceWriteDesc: Option[FileSourceWriteDesc] = None)
extends FileCommitProtocol with Serializable with Logging {
import FileCommitProtocol._
+ import HadoopMapReduceCommitProtocol._
+
+ def this(jobId: String, path: String, dpOverwrite: Boolean) = this(jobId,
path, dpOverwrite, None)
Review comment:
add three-arg constructor to make compatible with old version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
