srowen commented on issue #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#issuecomment-536199109 If the general question is, why hide things? just the usual software design idea, to only expose what you intend to support as a user or developer API. I'm not making a specific judgment about whether these should be exposed or not, just don't know yet. If the question is, can we make this more extensible, I also don't have a strong opinion but am not against it, but think that can be considered separately. There are also going to be a few follow-on PRs to this one to further remove some setters.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
