huaxingao commented on issue #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#issuecomment-536200993 @zero323 If your question is specific for this leading underscore I just added, there are two reasons: - To keep consistent with the previous implementation in ```_CountVectorizerParams``` and ```_StringIndexerParams``` - Since Python doesn't really have ```private``` modifier, seems to me the closest one is to have leading underscore specified in PEP 8 convention. https://www.python.org/dev/peps/pep-0008/ ```_single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose names start with an underscore.``` I am neural on this leading underscore. Since I am following Bryan's convention in ```_CountVectorizerParams```, I would like to check with him to see if there are any other reasons for this leading underscore. Thanks in advance @BryanCutler
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
