LantaoJin commented on a change in pull request #25944: [SPARK-29254][SQL]
Failed to include jars passed in through --jars when isolatedLoader is enabled
URL: https://github.com/apache/spark/pull/25944#discussion_r329333904
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
##########
@@ -334,6 +334,35 @@ class HiveSparkSubmitSuite
unusedJar.toString)
runSparkSubmit(argsForShowTables)
}
+
+ test("SPARK-29254: include jars passed in through --jars when isolatedLoader
is enabled") {
+ def getJarFromUrl(urlString: String): File = {
+ val fileName = urlString.split("/").last
+ Utils.doFetchFile(urlString, Utils.createTempDir(), fileName, new
SparkConf, null, null)
+ }
+ val repository =
"https://repository.apache.org/content/repositories/releases/";
+ val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
+ val jar1 = TestUtils.createJarWithClasses(Seq("SparkSubmitClassA"))
+ val jar2 = TestUtils.createJarWithClasses(Seq("SparkSubmitClassB"))
+ // download Hive 2.1.1, a non builtinHiveVersion(1.2.1) version for testing
+ val jar3 = getJarFromUrl(s"${repository}org/apache/hive/hive-contrib/" +
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
