srowen opened a new pull request #25968: 
[SPARK-29291][CORE][SQL][STREAMING][MLLIB] Change procedure-like declaration to 
function + Unit for 2.13
URL: https://github.com/apache/spark/pull/25968
 
 
   ### What changes were proposed in this pull request?
   
   Scala 2.13 emits a deprecation warning for procedure-like declarations:
   
   ```
   def foo() {
    ...
   ```
   
   This is equivalent to the following, so should be changed to avoid a warning:
   
   ```
   def foo(): Unit = {
     ...
   ```
   
   ### Why are the changes needed?
   
   It will avoid about a thousand compiler warnings when we start to support 
Scala 2.13. I wanted to make the change in 3.0 as there are less likely to be 
back-ports from 3.0 to 2.4 than 3.1 to 3.0, for example, minimizing that 
downside to touching so many files.
   
   Unfortunately, that makes this quite a big change.
   
   ### Does this PR introduce any user-facing change?
   
   No behavior change at all.
   
   ### How was this patch tested?
   
   Existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to