dongjoon-hyun commented on issue #25968: [SPARK-29291][CORE][SQL][STREAMING][MLLIB] Change procedure-like declaration to function + Unit for 2.13 URL: https://github.com/apache/spark/pull/25968#issuecomment-536354081 It's huge~ :) nit. Just for consistency, could you add `: Unit` for the following three, too? ``` $ git grep "run() = {" core/src/test/scala/org/apache/spark/SparkContextSuite.scala: val thread = new Thread() { override def run() = {result = sc.getLocalProperty("testProperty")}} core/src/test/scala/org/apache/spark/SparkContextSuite.scala: override def run() = {sc.setLocalProperty("testProperty", "testValue")}} core/src/test/scala/org/apache/spark/SparkContextSuite.scala: override def run() = {result = sc.getLocalProperty("testProperty")}} ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
