dongjoon-hyun commented on a change in pull request #25969:
[SPARK-29297][TESTS] Compare `core`/`mllib` module benchmarks in JDK8/11
URL: https://github.com/apache/spark/pull/25969#discussion_r329406071
##########
File path: core/benchmarks/PropertiesCloneBenchmark-jdk11-results.txt
##########
@@ -6,35 +6,35 @@ OpenJDK 64-Bit Server VM 11.0.4+11-LTS on Linux
3.10.0-862.3.2.el7.x86_64
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Empty Properties: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-SerializationUtils.clone 0 0
0 0.1 13755.0 1.0X
-Utils.cloneProperties 0 0
0 3.5 285.0 48.3X
+SerializationUtils.clone 0 0
0 0.1 11539.0 1.0X
+Utils.cloneProperties 0 0
0 1.7 572.0 20.2X
Review comment:
Thank you for review. Do you mean JDK11 is slower? Here, JDK8 took more
time. The following is the JDK8 result in this PR. JDK11 took `572.0ns` per row
while JDK8 did `608.0ns` per row.
```
SerializationUtils.clone 0 0
0 0.1 13640.0 1.0X
Utils.cloneProperties 0 0
0 1.6 608.0 22.4X
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
