[GitHub] [spark] wangyum commented on a change in pull request #25972: [SPARK-29300][TESTS] Compare `catalyst` and `avro` module benchmark in JDK8/11

Sun, 29 Sep 2019 23:21:14 -0700 

wangyum commented on a change in pull request #25972: [SPARK-29300][TESTS] 
Compare `catalyst` and `avro` module benchmark in JDK8/11
URL: https://github.com/apache/spark/pull/25972#discussion_r329421902
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SqlBasedBenchmark.scala
 ##########
 @@ -34,6 +35,7 @@ trait SqlBasedBenchmark extends BenchmarkBase with SQLHelper 
{
     SparkSession.builder()
       .master("local[1]")
       .appName(this.getClass.getCanonicalName)
+      .config(EXECUTOR_EXTRA_JAVA_OPTIONS, "-XX:+UseParallelGC 
-XX:-UseDynamicNumberOfGCThreads")
 
 Review comment:
   It seeems `EXECUTOR_EXTRA_JAVA_OPTIONS` not works for local mode. We need to 
use `DRIVER_EXTRA_JAVA_OPTIONS`:
   
![image](https://user-images.githubusercontent.com/5399861/65853774-2d373f00-e38d-11e9-9ed2-e09bea8aee9d.png)
   
![image](https://user-images.githubusercontent.com/5399861/65853856-78e9e880-e38d-11e9-90cb-2f8102d9566b.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to