AngersZhuuuu commented on a change in pull request #25977:
[SPARK-29268][SQL]isolationOn value is wrong in case of
spark.sql.hive.metastore.jars != builtin
URL: https://github.com/apache/spark/pull/25977#discussion_r329648383
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -385,7 +385,8 @@ private[spark] object HiveUtils extends Logging {
hadoopConf = hadoopConf,
config = configurations,
barrierPrefixes = hiveMetastoreBarrierPrefixes,
- sharedPrefixes = hiveMetastoreSharedPrefixes)
+ sharedPrefixes = hiveMetastoreSharedPrefixes,
+ isolationOn = !isCliSessionState)
Review comment:
One problem, when cli mode, isolationOn will be false.
SessionState in HiveClientImpl will use CliSessionState based on you buildin
hive version .
When you use maven to contain hive jars of other version. Can it still work
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
